Skip to content
Snippets Groups Projects
Select Git revision
0 results

checkbox.cpp

  • Arthur Sonzogni's avatar
    3b4ab618
    Prefer std::string over std::wstring. (#179) · 3b4ab618
    Arthur Sonzogni authored
    In the past, FTXUI switched from std::string to std::wstring to support
    fullwidth characters. The reasons was that fullwidth characters can be
    stored inside a single wchar_t.
    
    Then FTXUI added support for combining characters. A single glygh
    doesn't even fit a wchar_t. Instead, a glyph can be arbitrary large.
    
    The usage of wstring doesn't really fit the new model and have several
    drawbacks:
    1. It doesn't simplify the implementation of FTXUI, because of combining
       characters.
    2. It reduces drawing performance by 2x.
    3. It increase Screen's memory allocation by 2x.
    
    This patch converts FTXUI to use std::string internally. It now exposes
    std::string based API. The std::wstring API remains, but is now
    deprecated.
    
    Tests and examples haven't been update to show the breakage is limited.
    They will be updated in a second set of patches.
    
    Bug: https://github.com/ArthurSonzogni/FTXUI/issues/153
    
    
    Co-authored-by: default avatarTushar Maheshwari <tushar27192@gmail.com>
    3b4ab618
    History
    Prefer std::string over std::wstring. (#179)
    Arthur Sonzogni authored
    In the past, FTXUI switched from std::string to std::wstring to support
    fullwidth characters. The reasons was that fullwidth characters can be
    stored inside a single wchar_t.
    
    Then FTXUI added support for combining characters. A single glygh
    doesn't even fit a wchar_t. Instead, a glyph can be arbitrary large.
    
    The usage of wstring doesn't really fit the new model and have several
    drawbacks:
    1. It doesn't simplify the implementation of FTXUI, because of combining
       characters.
    2. It reduces drawing performance by 2x.
    3. It increase Screen's memory allocation by 2x.
    
    This patch converts FTXUI to use std::string internally. It now exposes
    std::string based API. The std::wstring API remains, but is now
    deprecated.
    
    Tests and examples haven't been update to show the breakage is limited.
    They will be updated in a second set of patches.
    
    Bug: https://github.com/ArthurSonzogni/FTXUI/issues/153
    
    
    Co-authored-by: default avatarTushar Maheshwari <tushar27192@gmail.com>