From 7e3e1d4bca7f1beaa1ccb21f6aeb29271b42b632 Mon Sep 17 00:00:00 2001
From: ArthurSonzogni <sonzogniarthur@gmail.com>
Date: Sun, 28 Apr 2024 10:39:30 +0200
Subject: [PATCH] Apply clang-tidy.
---
include/ftxui/screen/box.hpp | 2 +-
src/ftxui/component/dropdown.cpp | 6 +++---
src/ftxui/screen/box.cpp | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/ftxui/screen/box.hpp b/include/ftxui/screen/box.hpp
index 9fc27921..37708038 100644
--- a/include/ftxui/screen/box.hpp
+++ b/include/ftxui/screen/box.hpp
@@ -15,7 +15,7 @@ struct Box {
static auto Intersection(Box a, Box b) -> Box;
static auto Union(Box a, Box b) -> Box;
bool Contain(int x, int y) const;
- bool IsEmpty();
+ bool IsEmpty() const;
bool operator==(const Box& other) const;
bool operator!=(const Box& other) const;
};
diff --git a/src/ftxui/component/dropdown.cpp b/src/ftxui/component/dropdown.cpp
index 5f965807..e1058528 100644
--- a/src/ftxui/component/dropdown.cpp
+++ b/src/ftxui/component/dropdown.cpp
@@ -32,7 +32,7 @@ Component Dropdown(ConstStringListRef entries, int* selected) {
Component Dropdown(DropdownOption option) {
class Impl : public ComponentBase, public DropdownOption {
public:
- Impl(DropdownOption option) : DropdownOption(std::move(option)) {
+ explicit Impl(DropdownOption option) : DropdownOption(std::move(option)) {
FillDefault();
checkbox_ = Checkbox(checkbox);
radiobox_ = Radiobox(radiobox);
@@ -71,8 +71,8 @@ Component Dropdown(DropdownOption option) {
}
void FillDefault() {
- open_ = std::move(checkbox.checked);
- selected_ = std::move(radiobox.selected);
+ open_ = checkbox.checked;
+ selected_ = radiobox.selected;
checkbox.checked = &*open_;
radiobox.selected = &*selected_;
diff --git a/src/ftxui/screen/box.cpp b/src/ftxui/screen/box.cpp
index 0210153b..e190305e 100644
--- a/src/ftxui/screen/box.cpp
+++ b/src/ftxui/screen/box.cpp
@@ -41,7 +41,7 @@ bool Box::Contain(int x, int y) const {
/// @return whether the box is empty.
/// @ingroup screen
-bool Box::IsEmpty() {
+bool Box::IsEmpty() const {
return x_min > x_max || y_min > y_max;
}
--
GitLab