diff --git a/Makefile.build b/Makefile.build index 79cfbd76c0e95a56f8fc986df19340606b0be0bd..c54f871c82dabe39e188a5015efd728a413cc9cd 100644 --- a/Makefile.build +++ b/Makefile.build @@ -75,6 +75,7 @@ userprog_SRC += userprog/syscall_read.c userprog_SRC += userprog/syscall_filesize.c userprog_SRC += userprog/syscall_tell.c userprog_SRC += userprog/syscall_seek.c +userprog_SRC += userprog/syscall_close.c # No virtual memory code yet. #vm_SRC = vm/file.c # Some file. diff --git a/userprog/syscall.c b/userprog/syscall.c index c429f13727aa3c9f0b9a57a7c0de1b9b4d4d821d..845508adf10abcae3b2da8702c162ead639ca67a 100644 --- a/userprog/syscall.c +++ b/userprog/syscall.c @@ -91,6 +91,9 @@ syscall_handler (struct intr_frame *f UNUSED) case SYSCALL_SEEK: syscall_seek(f); break; + case SYSCALL_CLOSE: + syscall_close(f); + break; default: printf ("WARNING: Invalid Syscall (%d)\n", syscall_number); thread_exit (); diff --git a/userprog/syscall_close.c b/userprog/syscall_close.c index 651173b53910e646cfe56c9417fe49a87d495939..8508962b192b2548c16d014234cc2c19b29f37aa 100644 --- a/userprog/syscall_close.c +++ b/userprog/syscall_close.c @@ -14,7 +14,7 @@ void syscall_close(struct intr_frame *f) { // pop off first int argument from interrupt frame - int* file_descriptor = (void*)(*(int*)f->esp + 1); + int file_descriptor = *((int*)f->esp + 1); // Get file associated with file_descriptor struct file *file = get_associated_file_pointer(file_descriptor); if (file == NULL) { // Checking if file is empty or non-existent @@ -25,4 +25,4 @@ void syscall_close(struct intr_frame *f) { file_close(file); // Remove the file_descriptor disassociate_file_descriptor(file_descriptor); -} \ No newline at end of file +} diff --git a/userprog/syscall_seek.c b/userprog/syscall_seek.c index a623496bb1edb00c58b1cdc7001968b19239443c..9a665a14a14c72a36a04c1fea7b5766130fdf09b 100644 --- a/userprog/syscall_seek.c +++ b/userprog/syscall_seek.c @@ -13,10 +13,10 @@ void syscall_seek(struct intr_frame *f) { // pop off first int argument from interrupt frame - int* file_descriptor = (void*)*((int*)f->esp + 1); + int file_descriptor = *((int*)f->esp + 1); // pop off second int argument from interrupt frame - int* file_pos = (void*)(*(int*)f->esp + 2); + unsigned file_pos = *((unsigned*)((int*)f->esp + 2)); struct file *file = get_associated_file_pointer(file_descriptor); // Seek through the file file_seek(file, file_pos); -} \ No newline at end of file +} diff --git a/userprog/system_calls.h b/userprog/system_calls.h index 4f955ad8fbac861dd0bb64d5d7d8af3efec61382..49b8145675f486ef12405293fa3d3678426006d5 100644 --- a/userprog/system_calls.h +++ b/userprog/system_calls.h @@ -82,6 +82,12 @@ void syscall_tell(struct intr_frame *f); */ void syscall_seek(struct intr_frame *f); +/* + * Closes file descriptor fd. Exiting or terminating a process implicitly closes + * all its open file descriptors, as if by calling this function for each one. + */ +void syscall_close(struct intr_frame *f); + /* * special additional stuff for handling file descriptors because they're annoying */