From 41b84f84cc57a1ec48d0073a799833b567ddeba8 Mon Sep 17 00:00:00 2001 From: Hanmin Qin <qinhanmin2005@sina.com> Date: Mon, 5 Jun 2017 22:51:17 +0800 Subject: [PATCH] [MRG+1] Change the restriction of n_repeats in RepeatedKFold and RepeatedStratifiedKFold (#8909) * change the restriction of n_repeats * change test case --- sklearn/model_selection/_split.py | 4 ++-- sklearn/model_selection/tests/test_split.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sklearn/model_selection/_split.py b/sklearn/model_selection/_split.py index de889fab0b..369125f339 100644 --- a/sklearn/model_selection/_split.py +++ b/sklearn/model_selection/_split.py @@ -958,8 +958,8 @@ class _RepeatedSplits(with_metaclass(ABCMeta)): if not isinstance(n_repeats, (np.integer, numbers.Integral)): raise ValueError("Number of repetitions must be of Integral type.") - if n_repeats <= 1: - raise ValueError("Number of repetitions must be greater than 1.") + if n_repeats <= 0: + raise ValueError("Number of repetitions must be greater than 0.") if any(key in cvargs for key in ('random_state', 'shuffle')): raise ValueError( diff --git a/sklearn/model_selection/tests/test_split.py b/sklearn/model_selection/tests/test_split.py index e97fdce5e1..546609f413 100644 --- a/sklearn/model_selection/tests/test_split.py +++ b/sklearn/model_selection/tests/test_split.py @@ -832,9 +832,9 @@ def test_leave_one_p_group_out_error_on_fewer_number_of_groups(): def test_repeated_cv_value_errors(): - # n_repeats is not integer or <= 1 + # n_repeats is not integer or <= 0 for cv in (RepeatedKFold, RepeatedStratifiedKFold): - assert_raises(ValueError, cv, n_repeats=1) + assert_raises(ValueError, cv, n_repeats=0) assert_raises(ValueError, cv, n_repeats=1.5) -- GitLab