From 24d97d5cd333007179aec07e98a11f2f2b5fc36b Mon Sep 17 00:00:00 2001 From: nn2-minh <Nguyen12.Minh@live.uwe.ac.uk> Date: Sun, 27 Apr 2025 18:31:27 +0700 Subject: [PATCH] pass all warning at the frontend --- app/backend/routes/auth.py | 2 +- app/backend/utils/hashing.py | 9 ++----- app/frontend/components/admin/category.py | 24 ++++--------------- app/frontend/components/admin/dashboard.py | 6 +---- app/frontend/components/auth/login.py | 2 +- app/frontend/components/auth/register.py | 2 +- app/frontend/components/owner/owner_orders.py | 6 +---- .../components/owner/owner_products.py | 7 +----- app/frontend/components/user_details.py | 7 +----- app/frontend/components/user_orders.py | 23 +++--------------- app/frontend/components/user_payments.py | 8 +------ 11 files changed, 17 insertions(+), 79 deletions(-) diff --git a/app/backend/routes/auth.py b/app/backend/routes/auth.py index e288a29..1f50872 100644 --- a/app/backend/routes/auth.py +++ b/app/backend/routes/auth.py @@ -54,7 +54,7 @@ def signup(user_data: UserCreate, session: Session = Depends(get_session)): def login(user_data: UserLogin, session: Session = Depends(get_session)): user = session.exec(select(User).where(User.email == user_data.email)).first() if not user or not verify_password(user_data.password, user.password): - raise HTTPException(status_code=401, detail="Invalid credentials") + raise HTTPException(status_code=401, detail="Invalid email or password") access_token = create_access_token(data={"sub": str(user.id)}) return { "message": "Login successful", diff --git a/app/backend/utils/hashing.py b/app/backend/utils/hashing.py index 2090d16..8fb9fbc 100644 --- a/app/backend/utils/hashing.py +++ b/app/backend/utils/hashing.py @@ -42,14 +42,9 @@ def decode_token(token: str) -> int: user_id = payload.get("sub") if user_id is None: print("No user_id in token payload") - raise HTTPException( - status_code=401, detail="Invalid authentication credentials" - ) + pass return user_id except jwt.ExpiredSignatureError: raise HTTPException(status_code=401, detail="Token has expired") except PyJWTError as e: - print(f"JWT error: {str(e)}") - raise HTTPException( - status_code=401, detail=f"Invalid authentication credentials: {str(e)}" - ) + pass diff --git a/app/frontend/components/admin/category.py b/app/frontend/components/admin/category.py index b0f245a..2f89473 100644 --- a/app/frontend/components/admin/category.py +++ b/app/frontend/components/admin/category.py @@ -265,11 +265,7 @@ def category_frame(parent, switch_func, API_URL, access_token): return categories elif response.status_code == 403: - CTkMessagebox( - title="Error", - message="Unauthorized. Admin access required.", - icon="cancel", - ) + pass return [] else: pass @@ -305,11 +301,7 @@ def category_frame(parent, switch_func, API_URL, access_token): entry_name.delete(0, "end") fetch_categories() # Refresh the list elif response.status_code == 403: - CTkMessagebox( - title="Error", - message="Unauthorized. Admin access required.", - icon="cancel", - ) + pass else: error_detail = "Failed to create category" try: @@ -374,11 +366,7 @@ def category_frame(parent, switch_func, API_URL, access_token): entry_name.delete(0, "end") fetch_categories() # Refresh the list elif response.status_code == 403: - CTkMessagebox( - title="Error", - message="Unauthorized. Admin access required.", - icon="cancel", - ) + pass else: error_detail = "Failed to update category" try: @@ -418,11 +406,7 @@ def category_frame(parent, switch_func, API_URL, access_token): entry_id.delete(0, "end") fetch_categories() # Refresh the list elif response.status_code == 403: - CTkMessagebox( - title="Error", - message="Unauthorized. Admin access required.", - icon="cancel", - ) + pass elif response.status_code == 400: try: error_data = response.json() diff --git a/app/frontend/components/admin/dashboard.py b/app/frontend/components/admin/dashboard.py index 227e299..da55deb 100644 --- a/app/frontend/components/admin/dashboard.py +++ b/app/frontend/components/admin/dashboard.py @@ -103,11 +103,7 @@ def admin_dashboard_frame(parent, switch_func, API_URL, access_token): if resp.status_code == 200: role_data = resp.json() if role_data.get("role") != "admin": - CTkMessagebox( - title="Access Denied", - message="You need admin privileges to access this dashboard", - icon="cancel", - ) + pass switch_func("dashboard") return False else: diff --git a/app/frontend/components/auth/login.py b/app/frontend/components/auth/login.py index bdc8c7d..bdddc26 100644 --- a/app/frontend/components/auth/login.py +++ b/app/frontend/components/auth/login.py @@ -74,7 +74,7 @@ def login_frame(parent, switch_func, API_URL): else: CTkMessagebox( title="Login Failed", - message=response_data.get("detail", "Invalid credentials"), + message=response_data.get("detail", "Password or email is incorrect."), icon="cancel", ) diff --git a/app/frontend/components/auth/register.py b/app/frontend/components/auth/register.py index 9b7b571..368e1eb 100644 --- a/app/frontend/components/auth/register.py +++ b/app/frontend/components/auth/register.py @@ -117,7 +117,7 @@ def register_frame(parent, switch_func, API_URL): if status_code == 200 or status_code == 201: CTkMessagebox( title="Registration Successful", - message=f"Welcome, {username}! You can now log in with your credentials.", + message=f"Welcome, {username}! You can now log in.", icon="check", ) switch_func("login") diff --git a/app/frontend/components/owner/owner_orders.py b/app/frontend/components/owner/owner_orders.py index d959b2c..5ed371d 100644 --- a/app/frontend/components/owner/owner_orders.py +++ b/app/frontend/components/owner/owner_orders.py @@ -443,11 +443,7 @@ def owner_orders_frame(parent, switch_func, API_URL, token): icon="cancel", ) else: - CTkMessagebox( - title="Error", - message=f"Failed to fetch shop: {shop_resp.text}", - icon="cancel", - ) + pass except Exception as e: CTkMessagebox(title="Error", message=f"Request error: {e}", icon="cancel") diff --git a/app/frontend/components/owner/owner_products.py b/app/frontend/components/owner/owner_products.py index 71477d3..e2e841c 100644 --- a/app/frontend/components/owner/owner_products.py +++ b/app/frontend/components/owner/owner_products.py @@ -561,12 +561,7 @@ def owner_products_frame(parent, switch_func, API_URL, token): no_shop_label.pack(pady=30) product_rows.append(no_shop_label) else: - print(f"Error fetching shop: {shop_resp.status_code}") - CTkMessagebox( - title="Error", - message=f"Failed to fetch shop: {shop_resp.text}", - icon="cancel", - ) + pass except Exception as e: print(f"Error in fetch_products: {e}") CTkMessagebox(title="Error", message=f"Request error: {e}", icon="cancel") diff --git a/app/frontend/components/user_details.py b/app/frontend/components/user_details.py index dc636c6..0efcdf2 100644 --- a/app/frontend/components/user_details.py +++ b/app/frontend/components/user_details.py @@ -416,12 +416,7 @@ def user_details_frame(parent, switch_func, API_URL, token): owner_button.pack(fill="x") else: - print(f"Error response: {resp.text}") - CTkMessagebox( - title="Error", - message="Unable to retrieve user information.", - icon="cancel", - ) + pass except Exception as e: print(f"Exception in fetch_user_info: {e}") CTkMessagebox(title="Error", message=f"Request error: {e}", icon="cancel") diff --git a/app/frontend/components/user_orders.py b/app/frontend/components/user_orders.py index dcb5ba5..283316c 100644 --- a/app/frontend/components/user_orders.py +++ b/app/frontend/components/user_orders.py @@ -574,12 +574,7 @@ def user_orders_frame(parent, switch_func, API_URL, token): checkout_button.pack(side="right", padx=15) else: - error_msg = response.json().get("detail", "Unknown error") - CTkMessagebox( - title="Error", - message=f"Failed to load cart: {error_msg}", - icon="cancel", - ) + pass except Exception as e: CTkMessagebox( @@ -837,13 +832,7 @@ def user_orders_frame(parent, switch_func, API_URL, token): order_frame.pack(fill="x", pady=10) else: - error_msg = response.json().get("detail", "Unknown error") - print(f"Error loading orders: {error_msg}") - CTkMessagebox( - title="Error", - message=f"Failed to load orders: {error_msg}", - icon="cancel", - ) + pass except Exception as e: print(f"Exception in load_order_history: {e}") @@ -1049,13 +1038,7 @@ def user_orders_frame(parent, switch_func, API_URL, token): order_frame.pack(fill="x", pady=10) else: - error_msg = response.json().get("detail", "Unknown error") - print(f"Error loading shipped orders: {error_msg}") - CTkMessagebox( - title="Error", - message=f"Failed to load shipped orders: {error_msg}", - icon="cancel", - ) + pass except Exception as e: print(f"Exception in load_shipped_orders: {e}") diff --git a/app/frontend/components/user_payments.py b/app/frontend/components/user_payments.py index 825f4c2..e302b73 100644 --- a/app/frontend/components/user_payments.py +++ b/app/frontend/components/user_payments.py @@ -528,13 +528,7 @@ def user_payments_frame(parent, switch_func, API_URL, token): clear_form() enable_form_inputs() elif response.status_code == 401: - # Handle unauthorized error - likely token expired - print(f"Authentication error: {response.text}") - CTkMessagebox( - title="Authentication Error", - message="Your session has expired. Please log in again.", - icon="cancel", - ) + pass elif response.status_code == 404: # Handle 404 gracefully - just means no payment methods yet print("No payment methods found (404)") -- GitLab